Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close piece reader after generating indexes #1707

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Sep 21, 2023

Fixes filecoin-project/lotus#10935

  • Test on SP

@bobdubois
Copy link

this fix solved the issue of locked deleted files from the unsealed folder.

@LexLuthr LexLuthr marked this pull request as ready for review September 22, 2023 05:45
@LexLuthr LexLuthr merged commit 52f8bc7 into main Sep 22, 2023
20 checks passed
@LexLuthr LexLuthr deleted the fix/idx-pieceReader branch September 22, 2023 05:45
@strahe
Copy link
Contributor

strahe commented Oct 18, 2023

Should we release a fixed version? Currently the latest version v2.0.0 and 2.1.0-rc do not include this fix.

@LexLuthr
Copy link
Collaborator Author

@strahe Hey! We will cutting a new RC with the fix either today to tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unsealed file readers keep references to moved out files
4 participants