-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update deal filter to use ExpectedSealDuration
and MaxDealStartDelay
#1609
Conversation
docker/devnet/boost/entrypoint.sh
Outdated
@@ -77,6 +77,7 @@ fi | |||
## Override config options | |||
echo Updating config values | |||
sed -i 's|ServiceApiInfo = ""|ServiceApiInfo = "ws://localhost:8042"|g' $BOOST_PATH/config.toml | |||
sed -i 's|ExpectedSealDuration = "0h0m10s"|ExpectedSealDuration = "0h0m10s"|g' $BOOST_PATH/config.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm reading the code correctly it looks like this line doesn't do anything 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -628,7 +628,7 @@ func ConfigBoost(cfg *config.Boost) Option { | |||
Override(new(*storageadapter.DealPublisher), storageadapter.NewDealPublisher(&legacyFees, storageadapter.PublishMsgConfig{ | |||
Period: time.Duration(cfg.LotusDealmaking.PublishMsgPeriod), | |||
MaxDealsPerMsg: cfg.LotusDealmaking.MaxDealsPerPublishMsg, | |||
StartEpochSealingBuffer: cfg.LotusDealmaking.StartEpochSealingBuffer, | |||
StartEpochSealingBuffer: cfg.Dealmaking.StartEpochSealingBuffer, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include a comment about this change in the release announcement when this commit lands in a release.
Some SPs may be relying on this config flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, I will make an announcement.
fix devnet
…rtDelay` (#1609) * update deal filters * fix itests * adjust devnet values * Update docker/devnet/boost/entrypoint.sh fix devnet
Fixes #1608
This PR has the following changes:
ExpectedSealDuration
andMaxDealStartDelay
MaxDealStartDelay
to only factor in online deals. This was done keeping in mind that offline deals can take days to weeks for shipping & importing the data. We don't want them to be rejected because deal start epoch is too far away.