fix: update deal filter to use ExpectedSealDuration and MaxDealStartDelay
#1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2023 15:16
|
Both filters are working as expected: |
dirkmc
approved these changes
Aug 8, 2023
docker/devnet/boost/entrypoint.sh
Outdated
| @@ -77,6 +77,7 @@ fi | |||
| ## Override config options | |||
| echo Updating config values | |||
| sed -i 's|ServiceApiInfo = ""|ServiceApiInfo = "ws://localhost:8042"|g' $BOOST_PATH/config.toml | |||
| sed -i 's|ExpectedSealDuration = "0h0m10s"|ExpectedSealDuration = "0h0m10s"|g' $BOOST_PATH/config.toml | |||
There was a problem hiding this comment.
If I'm reading the code correctly it looks like this line doesn't do anything 🤔
| @@ -628,7 +628,7 @@ func ConfigBoost(cfg *config.Boost) Option { | |||
| Override(new(*storageadapter.DealPublisher), storageadapter.NewDealPublisher(&legacyFees, storageadapter.PublishMsgConfig{ | |||
| Period: time.Duration(cfg.LotusDealmaking.PublishMsgPeriod), | |||
| MaxDealsPerMsg: cfg.LotusDealmaking.MaxDealsPerPublishMsg, | |||
| StartEpochSealingBuffer: cfg.LotusDealmaking.StartEpochSealingBuffer, | |||
| StartEpochSealingBuffer: cfg.Dealmaking.StartEpochSealingBuffer, | |||
There was a problem hiding this comment.
We should include a comment about this change in the release announcement when this commit lands in a release.
Some SPs may be relying on this config flag.
There was a problem hiding this comment.
Ack, I will make an announcement.
LexLuthr
commented
Aug 8, 2023
fix devnet
LexLuthr
added a commit
that referenced
this pull request
Aug 8, 2023
…rtDelay` (#1609) * update deal filters * fix itests * adjust devnet values * Update docker/devnet/boost/entrypoint.sh fix devnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1608
This PR has the following changes:
ExpectedSealDurationandMaxDealStartDelayMaxDealStartDelayto only factor in online deals. This was done keeping in mind that offline deals can take days to weeks for shipping & importing the data. We don't want them to be rejected because deal start epoch is too far away.