-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP-0073: Remove the beneficiary from the self_destruct syscall #815
Merged
Stebalien
merged 3 commits into
filecoin-project:master
from
Stebalien:steb/self-destruct
Sep 1, 2023
Merged
FIP-0073: Remove the beneficiary from the self_destruct syscall #815
Stebalien
merged 3 commits into
filecoin-project:master
from
Stebalien:steb/self-destruct
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
anorth and
raulk
as code owners
August 30, 2023 00:48
jennijuju
reviewed
Aug 30, 2023
jennijuju
reviewed
Aug 30, 2023
jennijuju
reviewed
Aug 30, 2023
anorth
approved these changes
Aug 30, 2023
jennijuju
reviewed
Sep 1, 2023
FIPS/fip-XXX.md
Outdated
@@ -0,0 +1,104 @@ | |||
--- | |||
fip: <to be assigned> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIP-0073
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont forget to add to the readme too
jennijuju
changed the title
Remove the beneficiary from the self_destruct syscall
FIP-0073: Remove the beneficiary from the self_destruct syscall
Sep 1, 2023
jennijuju
approved these changes
Sep 1, 2023
Currently, actors can delete themselves and send away their funds (to another actor) in a single operation. Unfortunately, this doesn't behave exactly like a _normal_ transfer of funds and introduces some complexity. We propose to simplify this "self destruct" mechanism by requiring users to send away any remaining funds first through a normal send, if desired.
arajasek
approved these changes
Sep 1, 2023
Stebalien
force-pushed
the
steb/self-destruct
branch
from
September 1, 2023 19:03
ccfdb39
to
054a31a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, actors can delete themselves and send away their funds (to another actor) in a single operation. Unfortunately, this doesn't behave exactly like a normal transfer of funds and introduces some complexity. We propose to simplify this "self destruct" mechanism by requiring users to send away any remaining funds first through a normal send, if desired.
(this is a tiny FIP)