-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All V1 sealed proof sector expansion to 540 days #75
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
547b1ad
Create fip-0014.md
deltazxm 4e1cd91
Update fip-0014.md
deltazxm 326db9c
Update fip-0014.md
deltazxm f93139a
Update fip-0014.md
jennijuju f700d10
Update fip-0014.md
jennijuju 902b68b
Merge branch 'patch-1' of github.com:deltazxm/FIPs into jen/fip0014
jennijuju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
--- | ||
fip: "0014" | ||
title: V1 seal proof sectors extension | ||
author: deltazxm (@deltazxm), Neo Ge(@neogeweb3) | ||
discussions-to: https://github.com/filecoin-project/FIPs/issues/56 | ||
status: Draft | ||
type: Technical | ||
created: 2021-26-02 | ||
spec-sections: | ||
- section-systems.filecoin_mining.sector.lifecycle | ||
|
||
--- | ||
|
||
## Simple Summary | ||
Allow the life cycle of V1 proof sectors to be able to extend. | ||
Allow the V1 proof sectors life cycle extention. | ||
|
||
## Abstract | ||
All the V1 proof sectors are sealed with collaterals and gas fees, but they have not received the same treatment as other sectors. The security issue of V1 proof sectors are not enough to threaten the chain security. So this proposal allows the V1 proof sectors lifecycle to be extended. | ||
|
||
## Change Motivation | ||
In the case of network security, the fairness of the decentralized network needs to be guaranteed. Miners with V1 proof sectors have also gone through the strict sealing process, and have paid the collaterals and gas. The V1 proof sectors lifecycle should be allowed to extended without affecting the chain security. | ||
Although the V1 sectors have some security vulnerabilities, these security factors are not enough to constitute a reason for not allowing extensions. This is not a vulnerability that threatens the security of the chain, so extension should be allowed. | ||
|
||
### Actor changes | ||
var ExtensibleProofTypesV7 = map[abi.RegisteredSealProof]struct{}{ | ||
abi.RegisteredSealProof_StackedDrg32GiBV1: {}, | ||
abi.RegisteredSealProof_StackedDrg64GiBV1: {}, | ||
abi.RegisteredSealProof_StackedDrg32GiBV1_1: {}, | ||
abi.RegisteredSealProof_StackedDrg64GiBV1_1: {}, | ||
} | ||
|
||
## Test Cases | ||
N/A | ||
|
||
## Implementation | ||
The changes to the miner actor are in: https://github.com/filecoin-project/specs-actors/pull/1310 | ||
|
||
## Security Considerations | ||
N/A | ||
|
||
## Incentive Considerations | ||
After making this change, V1 proof sectors lifecycle will be extended and continue to receive block rewards. | ||
## Product Considerations | ||
N/A | ||
|
||
## Copyright | ||
|
||
Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/). |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are actually significant security considerations for v1 vs v1.1 sectors (which is why the network upgraded to v1.1 sectors in the first place). Can you clarify how this proposal will upgrade v1 sectors to ensure they are as secure as v1.1 sectors to make them eligible for extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what @deltazxm was trying to say is to extend v1 proof sector lifecycle instead of upgrading v1 to v1.1. I will quote @deltazxm below "Only sectors sealed prior to November 24th, 2020 have the issue, it's not financially beneficial for anyone to develop specific chips to hack these sectors. Sectors sealed prior to November 24th, 2020 have different lengths of the lifecycle (180/360/540 days), if lifecycle extension is not approved, at least we expect some fairness on this. In another word, change all the lifecycle to 540 days, then let them die after that. "