Update FIP0056 based on implementation #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The minimum duration is 540 days, not 1.5 years. It's a small difference, but important. - The implementation recalculates SDM from the current epoch on replica update (see #554 (comment)). - The `sdm` pseudo code lead to a maximum multiplier of 1e6, which was clearly a mistake. - This now documents the update to replaced day rewards, etc. - This now documents the correct termination penalty calculation (still under discussion, but the old version was broken).
Stebalien
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
anorth and
raulk
as code owners
anorth
approved these changes
Apr 6, 2023
|
|
||
| ``` | ||
| fn sdm(duration_commitment: float) -> float { | ||
| if duration_commitment <= (3/2 * EPOCHS_IN_YEAR) { | ||
| fn sdm_scale(base_power: int, duration_commitment: int) -> int { |
|
Thanks! |
kaitlin-beegle
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdmpseudo code lead to a maximum multiplier of 1e6, which was clearly a mistake.