FIP-0100: artificially bump calibnet circulating supply up further to match mainnet#1133
FIP-0100: artificially bump calibnet circulating supply up further to match mainnet#1133
Conversation
rvagg
requested review from
TippyFlitsUK,
anorth,
dannyob,
jennijuju,
jsoares,
lanzafame and
momack2
as code owners
| | `InitialFilReserved` | 300,000,000 | 1,200,000,000 | | ||
| | `FilReserveDisbursed` | 17,066,619 | 300,721,729 | |
There was a problem hiding this comment.
We're increasing the reserve by 300k, but then increasing dispersed by 270k. Is that what we mean to do? It looks like it'll work, I just wanted to double check.
There was a problem hiding this comment.
Yeah, though I got this wrong and need to update it, I added an extra 0 instead of a a 3 when pushing it up by another 300k:
| | `InitialFilReserved` | 300,000,000 | 1,200,000,000 | | |
| | `FilReserveDisbursed` | 17,066,619 | 300,721,729 | | |
| | `InitialFilReserved` | 300,000,000 | 1,200,000,000 | | |
| | `FilReserveDisbursed` | 17,066,619 | 330,721,729 | |
This gets us to ~695M circulating supply.
The real number for FilReserveDisbursed right now on calibnet with this adjustment would be 330,855,429, but the original is close enough. I just need to confirm the 695M / 686M discrepancy between this doc and my current calcs, it seems a bit large.
Equation details written up in long-form and code here: filecoin-project/lotus#12938, the juicy bits are:
The basic equation for circulating supply is:
FilReserveDisbursed is the thing we're going to tinker with, it's further broken down as:
...
Calibnet 300M -> 1.2B
There was a problem hiding this comment.
ok, so the discrepancy is calibnet growth since I got the original numbers
# Current CS:
323483605 + 68672646 + (300000000 - 869278271) - 32117860 - 3893484 = -213133364
# FIP-0100 CS:
323483605 + 68672646 + (900000000 - 869278271) - 32117860 - 3893484 = 386866636
# This change:
323483605 + 68672646 + (1200000000 - 869278271) - 32117860 - 3893484 = 686866636
# This change w/ current calibnet numbers:
332296928 + 70878601 + (1200000000 - 869278271) - 33776947 - 4250794 = 695869517
… match mainnet 900M is the correct value for `InitialFilReserved` on calibration net, which is what we're trying to address to make circulating supply non-negative. But it lands us at a CS value of ~386M. This change proposes to artificially raise `InitialFilReserved` by another 300M to bring CS to ~686M which is very close to the current mainnet CS value (~686M). It is expected that these numbers will continue to diverge over time, but having them close together is useful to increase the fidelity of testing change implementations, particularly for this FIP right now.
…ther to match mainnet
rvagg
force-pushed
the
rvagg/fip-0100/calibnet-tweak
branch
from
4cde32a to
cf71492
Compare
4 participants
900M is the correct value for
InitialFilReservedon calibration net, which is what we're trying to address to make circulating supply non-negative. But it lands us at a CS value of ~386M. This change proposes to artificially raiseInitialFilReservedby another 300M to bring CS to ~686M which is very close to the current mainnet CS value (~686M). It is expected that these numbers will continue to diverge over time, but having them close together is useful to increase the fidelity of testing change implementations, particularly for this FIP right now.Coming out of some discussion in filecoin-project/lotus#12938