Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locales(uk_UA, ru_RU) #56

Closed
wants to merge 1 commit into from
Closed

Locales(uk_UA, ru_RU) #56

wants to merge 1 commit into from

Conversation

s-chizhik
Copy link

Hi. I'd like to add two locales.

fightbulc
fightbulc reviewed Aug 31, 2015
View reviewed changes
src/Locales/ru_RU.php
"lastDay" => '[Вчера]',
"lastWeek" => '[Прошлая неделя] l',
"sameElse" => 'l',
"withTime" => '[at] H:i',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the time?

@fightbulc
Copy link
Owner

@s-chizhik Hey there. Love to see that the list of translations is growing. I had two remarks above. As soon as they are in I'll merge. Thanks!

@s-chizhik
Copy link
Author

@fightbulc ok, i got it. I'll make it as soon as i can. Maybe you would provide unit test example to test common cases and prevent such mistakes? I saw MomentGermanLocaleTest but it does not cover all use-cases.

@fightbulc
Copy link
Owner

@s-chizhik Yes, I do have to take some time and implement some testing. Time is as always the challenge here.

@s-chizhik
Copy link
Author

Hi. I noticed that there is no support of accusative and nominative versions of months, weeks, etc. So some calendar methods can give not fully correct result for this two locales. Is it ok? If you'll add this feature soon, I going to update locale. Or maybe I'll add feature and fix locales?

@fightbulc
Copy link
Owner

Hey there. Sure, man. I am happy if moment gets more sophisticated. Looking forward. Cheers

@fightbulc
Copy link
Owner

Hey there. Going to close this for now. Send a new request when you found the time. Thanks.

@fightbulc fightbulc closed this Nov 20, 2015
@fightbulc fightbulc mentioned this pull request Mar 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-chizhik @fightbulc