Skip to content

Commit

Permalink
Revert "update v4 metadata to return network stats despite missing st…
Browse files Browse the repository at this point in the history
…ats for single container (aws#2719)"

This reverts commit 7a82ee7.
  • Loading branch information
fierlion committed Nov 12, 2020
1 parent bacc344 commit 9b0aa80
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion agent/handlers/v4/task_metadata_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,12 @@ func TaskMetadataHandler(state dockerstate.TaskEngineState, ecsClient api.ECSCli
for _, containerResponse := range taskResponse.Containers {
networks, err := GetContainerNetworkMetadata(containerResponse.ID, state)
if err != nil {
seelog.Warnf("Error retrieving network metadata for container %s - %s", containerResponse.ID, err)
errResponseJSON, err := json.Marshal(err.Error())
if e := utils.WriteResponseIfMarshalError(w, err); e != nil {
return
}
utils.WriteJSONToResponse(w, http.StatusInternalServerError, errResponseJSON, utils.RequestTypeContainerMetadata)
return
}
containerResponse.Networks = networks
responses = append(responses, containerResponse)
Expand Down

0 comments on commit 9b0aa80

Please sign in to comment.