Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing updates + post hook methods #245

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Typing updates + post hook methods #245

merged 2 commits into from
Apr 18, 2022

Conversation

ncilfone
Copy link
Contributor

What does this PR do?

fixes to some typing stubs. added in a new post hook util to check lengths of a list of iterables. added allow optional to all post hook methods to deal with optional types

Checklist

  • Did you adhere to PEP-8 standards?
  • Did you run black and isort prior to submitting your PR?
  • Does your PR pass all existing unit tests?
  • Did you add associated unit tests for any additional functionality?
  • Did you provide documentation (Google Docstring format) whenever possible, even for simple functions or classes?

…ngths of a list of iterables. added allow optional to all post hook methods to deal with optional types
@coveralls
Copy link

coveralls commented Apr 18, 2022

Pull Request Test Coverage Report for Build 2185598700

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 45 of 50 (90.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 95.776%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spock/utils.py 36 41 87.8%
Totals Coverage Status
Change from base Build 2168031906: -0.04%
Covered Lines: 1950
Relevant Lines: 2036

💛 - Coveralls

@ncilfone ncilfone merged commit 6ac93d7 into master Apr 18, 2022
@ncilfone ncilfone deleted the random_edits branch April 18, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants