Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Issue with Optional parameters that are inherited #222

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

ncilfone
Copy link
Contributor

What does this PR do?

fixed issue with inheritance of Optional classes with the new lazy base classes

Checklist

  • Did you adhere to PEP-8 standards?
  • Did you run black and isort prior to submitting your PR?
  • Does your PR pass all existing unit tests?
  • Did you add associated unit tests for any additional functionality?
  • Did you provide documentation (Google Docstring format) whenever possible, even for simple functions or classes?

@ncilfone ncilfone added the bug Something isn't working label Feb 18, 2022
@coveralls
Copy link

coveralls commented Feb 18, 2022

Pull Request Test Coverage Report for Build 1866527872

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 96.104%

Files with Coverage Reduction New Missed Lines %
spock/graph.py 1 94.17%
Totals Coverage Status
Change from base Build 1865855495: 0.1%
Covered Lines: 1776
Relevant Lines: 1848

💛 - Coveralls

@ncilfone ncilfone merged commit a07c209 into master Feb 18, 2022
@ncilfone ncilfone deleted the optional_fix branch March 14, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants