-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of nested dependencies #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssuming to fall back on defaults instead of recursing the config space to set the correct parameters.
…ng recursed to set config arg values within nested classes.
…ctor should be thought about to handle all the parent/child relations in a cleaner manner
…. Probably a bunch of vestigial code still to remove -- base tests still only 43/48
and doc string
Sounds good. Thank you for this library! |
…s. Some now raise a different exception with the new refactor
Pull Request Test Coverage Report for Build 1574694571
💛 - Coveralls |
…t' yet only 'typing.List'
@gbmarc1 Merging into master. Thank you again for all the work on this! |
ncilfone
added a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR uses simple graph methods to better handle nested dependencies. Also contains a fairly big refactor of some original spaghetti backend code into a much cleaner interface. Mainly contributed by @gbmarc1 via fork. This should close #152.
Checklist