Skip to content

Commit

Permalink
memory leak fix
Browse files Browse the repository at this point in the history
  • Loading branch information
jsermeno committed Mar 9, 2016
1 parent 19f4b31 commit 8a79d8b
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions src/js/waves.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,14 @@
for (var i = 0, len = ripples.length; i < len; i++) {
removeRipple(e, element, ripples[i]);
}

if (isTouchAvailable) {
element.removeEventListener('touchend', Effect.hide);
element.removeEventListener('touchcancel', Effect.hide);
}

element.removeEventListener('mouseup', Effect.hide);
element.removeEventListener('mouseleave', Effect.hide);
}
};

Expand Down Expand Up @@ -417,6 +425,8 @@
hidden = true;
Effect.hide(hideEvent, element);
}

removeListeners();
};

var touchMove = function(moveEvent) {
Expand All @@ -425,12 +435,19 @@
timer = null;
}
hideEffect(moveEvent);

removeListeners();
};

element.addEventListener('touchmove', touchMove, false);
element.addEventListener('touchend', hideEffect, false);
element.addEventListener('touchcancel', hideEffect, false);

var removeListeners = function() {
element.removeEventListener('touchmove', touchMove);
element.removeEventListener('touchend', hideEffect);
element.removeEventListener('touchcancel', hideEffect);
};
} else {

Effect.show(e, element);
Expand Down

0 comments on commit 8a79d8b

Please sign in to comment.