fix: sonarqube issues

- fixed various issues spotted by sonarqube

client/public/locales/de/translation.json

@@ -48,6 +48,8 @@
   "careful_misty_bullock_splash": "Schritt 3: Teilen Sie Ihren Link",
   "game_frail_vole_treasure": "Erledigt! Glückwunsch!",
   "still_helpful_koala_trust": "Sobald ein Benutzer einen Termin bucht, wird das Ereignis Ihrem Kalender hinzugefügt.",
+  "steep_fine_lobster_inspire": "Terminart konnte nicht gespeichert werden",
+  "best_due_parakeet_zip": "Terminart angelegt",
   "Name": "Name",
   "Please provide your name": "Bitte geben Sie Ihren Namen an",
   "Email": "E-Mail-Adresse",
@@ -66,6 +68,6 @@
   "Choose date": "Datum wählen",
   "Choose time": "Uhrzeit wählen",
   "Provide details": "Details angeben",
-  "steep_fine_lobster_inspire": "Terminart konnte nicht gespeichert werden",
-  "best_due_parakeet_zip": "Terminart angelegt"
+  "happy_caring_fox_spur": "Terminart gespeichert",
+  "tasty_witty_stingray_hope": "Fehler beim Speichern der Terminart"
 }

client/public/locales/en/translation.json

@@ -54,5 +54,7 @@
   "game_frail_vole_treasure": "Done! Congrats!",
   "still_helpful_koala_trust": "Once a user books an appointment, the event is added to your calendar.",
   "steep_fine_lobster_inspire": "Failed to save event type",
-  "best_due_parakeet_zip": "Event type created!"
+  "best_due_parakeet_zip": "Event type created!",
+  "happy_caring_fox_spur": "Event saved",
+  "tasty_witty_stingray_hope": "Error saving event"
 }

client/src/index.tsx

@@ -8,7 +8,6 @@ import Login from "./pages/Login";
 import Landing from "./pages/Landing";
 import AddEvent from "./pages/AddEvent";
 import Planning from "./pages/Planning";
-import Schedule from "./pages/Schedule";
 import NotFound from "./pages/NotFound";
 import Booking from "./pages/Booking";
 import EditEvent from "./pages/EditEvent";
@@ -142,10 +141,6 @@ root.render(
                     path="/landing"
                     element={<Landing />}
                   />
-                  <Route
-                    path="/schedule/:user_url/:url"
-                    element={<Schedule />}
-                  />
                   <Route
                     path="/users/:user_url"
                     element={<Planning />}

client/src/pages/Booking.tsx

@@ -85,11 +85,11 @@ const Booking = (props: any) => {
   const [skipped, setSkipped] = React.useState(new Set());
   const [event, setEvent] = useState<Event>(EMPTY_EVENT);
   const [selectedDate, setDate] = useState<Date>();
-  const [beginDate, setBeginDate] = useState<Date>(new Date());
+  const [beginDate] = useState<Date>(new Date());
   const [slots, setSlots] = useState<IntervalSet>();
-  const [selectedTime, setTime] = useState<Date>();
+  const [selectedTime, setSelectedTime] = useState<Date>();
   const [details, setDetails] = useState<Details>();
-  const [isPending, startTransition] = useTransition()
+  const [, startTransition] = useTransition()
 
   const updateSlots = (startDate: Date) => {
     getAvailableTimes(
@@ -180,9 +180,7 @@ const Booking = (props: any) => {
   };
 
   const handleMonthChange = (date: Date) => {
-    //setBeginDate(date);
     console.log("handleMonthChange: %o", date);
-    //updateSlots(date);
   };
 
   const handleDateChange = (newValue: Date) => {
@@ -194,7 +192,6 @@ const Booking = (props: any) => {
   const steps = ["Choose date", "Choose time", "Provide details"].map((label) => t(label));
 
   const checkDay = (date: Date) => {
-    //console.log("checkDay: %o %o", slots, event.available);
     if (!event.available) {
       return false;
     } else {
@@ -221,7 +218,6 @@ const Booking = (props: any) => {
   const renderPickerDay = (
     props: PickersDayProps<Date> & { selectedDate: Date | null }) => {
     const { day } = props;
-    //console.log("rendering day: %o %o", day, props);
     return (
       <StyledPickersDay
         {...props}
@@ -259,7 +255,7 @@ const Booking = (props: any) => {
     (time: Date) => (event: React.MouseEvent<HTMLButtonElement>) => {
       console.log("time: %o", time);
       setActiveStep(2);
-      setTime(time);
+      setSelectedTime(time);
     };
 
   const renderSlots = () => {

client/src/pages/CalendarInt.tsx

@@ -20,14 +20,13 @@ import {
   FormControl,
   FormControlLabel,
   FormGroup,
-  Grid,
   InputLabel,
   MenuItem,
   Select,
   Typography,
   IconButton,
 } from "@mui/material";
-
+import Grid from "@mui/material/Grid2";
 
 
 //import { Button, Modal } from "react-bootstrap";
@@ -50,7 +49,7 @@ const renderCalendarList = (calendarList, state, setState, single = false) => {
     console.log("selected: %o", selected);
     const items = calendarList.items.map((item) => {
       return (
-        <MenuItem value={item.id}>
+        <MenuItem key={item.id} value={item.id}>
           {item.summaryOverride ? item.summaryOverride : item.summary}
         </MenuItem>
       );
@@ -77,6 +76,7 @@ const renderCalendarList = (calendarList, state, setState, single = false) => {
   } else {
     const items = calendarList.items.map((item) => (
       <FormControlLabel
+        key={item.id}
         control={
           <Checkbox
             checked={state[item.id] ? true : false}
@@ -179,7 +179,7 @@ const PullCalendars = ({ user, calendarList }) => {
     ? calendarList.items
       .filter((item) => user.pull_calendars.includes(item.id))
       .map((cal) => (
-        <li>{cal.summaryOverride ? cal.summaryOverride : cal.summary}</li>
+        <li key={cal.id}>{cal.summaryOverride ? cal.summaryOverride : cal.summary}</li>
       ))
     : undefined;
 
@@ -261,7 +261,7 @@ const PullCalendars = ({ user, calendarList }) => {
 };
 
 const Calendarintegration = () => {
-  const token = JSON.parse(localStorage.getItem("access_token") as string);
+  const token = JSON.parse(localStorage.getItem("access_token"));
   const navigate = useNavigate();
   const [connected, setConnected] = useState(false);
   const [url, setUrl] = useState("");
@@ -280,7 +280,7 @@ const Calendarintegration = () => {
   };
 
   useEffect(() => {
-    if (!user || !user.google_tokens || !user.google_tokens.access_token) {
+    if (!user?.google_tokens?.access_token) {
       setConnected(false);
       console.log("no user or no access token: %o", user);
     } else {
@@ -351,7 +351,7 @@ const Calendarintegration = () => {
             justifyContent="space-between"
             alignItems="center"
           >
-            <Grid item>
+            <Grid>
               <img
                 className="icon"
                 alt="Google Calendar"
@@ -360,7 +360,7 @@ const Calendarintegration = () => {
               />{" "}
               Google Calendar
             </Grid>
-            <Grid item>{renderConnectButton()}</Grid>
+            <Grid>{renderConnectButton()}</Grid>
           </Grid>
         </Box>
 

client/src/pages/EditEvent.tsx

@@ -8,6 +8,7 @@ import { signout } from "../helpers/helpers";
 import { EventForm } from "../components/EventForm";
 import { EMPTY_EVENT, Event } from "common";
 import { useTranslation } from "react-i18next";
+import { useSnackbar } from "notistack";
 
 export type EventFormProps = {
   event: Event;
@@ -22,6 +23,7 @@ const EditEvent = (): JSX.Element => {
   const navigate = useNavigate();
   const [formData, setFormData] = useState<Event>(EMPTY_EVENT);
   const { t } = useTranslation();
+  const { enqueueSnackbar } = useSnackbar();
 
   useEffect(() => {
     getEventByID(token, eventID).then((res) => {
@@ -42,13 +44,13 @@ const EditEvent = (): JSX.Element => {
           signout();
           navigate("/landing");
         } else {
-          //toast.success(res.data.msg);
+          enqueueSnackbar(t("happy_caring_fox_spur"), { variant: "success" });
           navigate("/app");
         }
       })
       .catch((err) => {
         console.log(err);
-        //toast.error("Failed to save event type");
+        enqueueSnackbar(t("tasty_witty_stingray_hope"), { variant: "error" });
       });
   };