Disable Launchy using ENV variable instead of completely redefining deliver!
method.
#73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a new version of
letter_opener
is released and there's a change inLetterOpener::Message.rendered_messages
method (now we send location usingoptions
param)letter_opener_web
is broken whenletter_opener_web
as delivery method is used (sorry about that).There's a bug report about it here ryanb/letter_opener#147. I think it makes sense to disable Launchy using
LAUNCHY_DRY_RUN
env variable (https://github.com/copiousfreetime/launchy/blob/master/lib/launchy.rb#L15) to avoid future issues with compatibilities withletter_opener
gem. What do you think?