Fix All Them Rubocop Warnings #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iguchi1124 I noticed you pinged me about #70, I'm sorry I didn't see it before. In the future feel free to ping me directly on issues/PRs. In order for CI to pass on #70, I think we'll need to merge this and have you rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there's a dependency on rubocop
~> 0.47it gets updated on CI often. This is cool and expected, but does sometimes lead to issues where new branches that should pass CI, fail due to updated linting rules.This updated all the warnings that were output by rubocop. (Mostly just
be rubocop -a)