chore(deps): bump fgumi to 0.5.0 - #20
Conversation
Picks up the 0.5.0 sort engine, including single-pass `--verify` (streams the input instead of re-opening it), streamed sort ingest, narrower radix passes, a pool-integrated `--write-index` merge, and the new `--sort-threads` / `--merge-threads` / `--max-temp-files` flags, which surface automatically through the flattened `Sort`. Test 10 asserted the old behavior — that `--verify` rejected a non-seekable stdin stream up front, because verify needed to re-read its input. Single-pass verify removed that limitation, so the test now locks in the new behavior instead: verify from a piped stdin exits 0 on a sorted stream and non-zero on an unsorted one. Asserting both directions keeps the pass non-vacuous — together they prove the stream was actually consumed and its order evaluated, rather than verify short-circuiting on an empty read.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe ChangesStdin verification
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bumps the sort engine from fgumi 0.3.1 to 0.5.0, released today. One-line dependency bump plus one test update for an upstream behavior change; no original sort code added here.
What mako picks up
Sort-relevant highlights from the 0.4.0 + 0.5.0 changelogs:
--verify(#568, #594) — verify now streams its input once (header parsed through a tee, consumed bytes replayed) instead of re-opening the path, and bounds run comparison to O(order divergence).--write-indexmerge (#647).Sort—--sort-threads/--merge-threadsfor per-phase thread control (#608),--max-temp-filesto tune spill-file consolidation (#643),--index-threshold always|never(#632).@HD SSwritten as<sort-order>:<sub-sort>with the spec spellinglexicographical(#514, #567), and secondary/supplementary reads placed at the exact template coordinate viatc(#529).0.5.0 carries several
[breaking]entries, but all of them are in commands mako does not expose (group, dedup, consensus, codec, compare). MSRV is unchanged at 1.93.0, matchingrust-toolchain.toml, so no toolchain bump.Test change
Test 10 asserted the old behavior: that
--verifyrejected a non-seekable stdin stream up front with a message mentioning stdin, because verify needed to re-read its input. Single-pass verify removes that limitation, so the assertion is now testing behavior that no longer exists — it failed withBAM file is NOT correctly sorted by Coordinate: 1 violations found, i.e. verify had happily consumed the pipe and done its job.verify_rejects_stdin_inputis replaced withverify_accepts_stdin_input, which locks in the new behavior: verify from a piped stdin exits 0 on a sorted stream and non-zero on an unsorted one. Both directions are asserted deliberately — together they prove the stream was actually consumed and its order evaluated, rather than verify short-circuiting on an empty read (a one-sided pass-only assertion would be satisfied by a verify that read nothing). Both-and/dev/stdinare still exercised, since the latter is a real existing path.Verification
Version banner confirms the resolved dependency:
Follow-up (not fixed here)
fgumi's
--sort-threadshelp text contains abwa mem -t 32 ... | fgumi sort -@ 8 --sort-threads 4example, somako --helpnow shows onefgumi sortinvocation. Cosmetic, and it belongs upstream in fgumi's arg doc comment rather than in this repo.Summary by CodeRabbit
mako --verifynow supports validating BAM data streamed through standard input.