Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add is active almanac update #564

Merged
merged 10 commits into from
Oct 22, 2024
Merged

feat(core): add is active almanac update #564

merged 10 commits into from
Oct 22, 2024

Conversation

lrahmani
Copy link
Contributor

No description provided.

@lrahmani lrahmani changed the title feat: add is active almanac update feat(core): add is active almanac update Oct 21, 2024
@lrahmani lrahmani force-pushed the feat/add-is-running-message branch 2 times, most recently from b66bcd8 to 68f9ec6 Compare October 21, 2024 06:50
Archento
Archento requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

We should refactor the registration code a bit to remove the duplicate code bits but once that's done it's good!

python/src/uagents/registration.py Show resolved Hide resolved
python/src/uagents/registration.py Outdated Show resolved Hide resolved
python/src/uagents/registration.py Outdated Show resolved Hide resolved
Archento
Archento previously approved these changes Oct 21, 2024
View reviewed changes
Archento
Archento previously approved these changes Oct 22, 2024
View reviewed changes
@Archento Archento enabled auto-merge (squash) October 22, 2024 08:29
@jrriehl jrriehl disabled auto-merge October 22, 2024 09:27
@jrriehl jrriehl merged commit 4a5f960 into main Oct 22, 2024
3 of 9 checks passed
@jrriehl jrriehl deleted the feat/add-is-running-message branch October 22, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrriehl jrriehl jrriehl approved these changes

@Archento Archento Archento left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lrahmani @jrriehl @Archento