Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): agent registration if no endpoint is provided #478

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix(core): agent registration if no endpoint is provided #478

merged 2 commits into from
Jul 31, 2024

Conversation

Archento
Copy link
Member

Proposed Changes

If an agent does not have an endpoint configured it should not register on the Almanac.

Types of changes

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

@Archento Archento merged commit b83a0a2 into main Jul 31, 2024
9 checks passed
@Archento Archento deleted the fix/agent-registration-no-endpoint branch July 31, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrriehl jrriehl jrriehl approved these changes

@lrahmani lrahmani Awaiting requested review from lrahmani lrahmani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archento @jrriehl