Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): minor cleanup #474

Merged
merged 12 commits into from
Aug 5, 2024
Merged

chore(core): minor cleanup #474

merged 12 commits into from
Aug 5, 2024

Conversation

Archento
Copy link
Member

Proposed Changes

Fixing a couple of inconsistencies.

Types of changes

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added/updated the documentation

jrriehl
jrriehl previously approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Archento Archento merged commit 1721ee0 into main Aug 5, 2024
9 checks passed
@Archento Archento deleted the chore/minor-cleanup branch August 5, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrriehl jrriehl jrriehl approved these changes

@lrahmani lrahmani Awaiting requested review from lrahmani lrahmani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archento @jrriehl