Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): agent registration endpoint mismatch #466

Merged
merged 4 commits into from
Jul 19, 2024
Merged

fix(core): agent registration endpoint mismatch #466

merged 4 commits into from
Jul 19, 2024

Conversation

Archento
Copy link
Member

Proposed Changes

Fixes a current bug in agent registration when the agent uses the mailbox.
Also fixes properly handling a KeyboardInterrupt in Agent and Bureau.

Linked Issues

Closes #447

Types of changes

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease
  • I have added/updated the documentation

@Archento Archento requested a review from jrriehl July 19, 2024 10:07
@Archento Archento requested a review from lrahmani as a code owner July 19, 2024 10:07
jrriehl
jrriehl approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Archento Archento merged commit 58f4bcf into main Jul 19, 2024
9 checks passed
@Archento Archento deleted the fix/agent-registration-endpoint-mismatch branch July 19, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrriehl jrriehl jrriehl approved these changes

@lrahmani lrahmani Awaiting requested review from lrahmani lrahmani is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyboardInterrupt raises error in Agent and Bureau
2 participants
@Archento @jrriehl