Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve request header parsing #166

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: improve request header parsing #166

merged 1 commit into from
Sep 19, 2023

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Sep 19, 2023

  • Fixes issue where connecting from browser results in an uncaught 500 error
  • Returns status OK when connecting from browser
  • More informative error messages

@jrriehl jrriehl linked an issue Sep 19, 2023 that may be closed by this pull request
Exception/crash when connecting to an agent through browser #153
Closed
@jrriehl jrriehl linked an issue Sep 19, 2023 that may be closed by this pull request
Do correct parsing of http headers #35
Closed
Archento
Archento approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@Archento Archento left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the more precise responses.
Also: It works as expected :)

@jrriehl jrriehl merged commit b42d02d into main Sep 19, 2023
7 checks passed
@jrriehl jrriehl deleted the fix/header-parsing branch September 19, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archento Archento Archento approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception/crash when connecting to an agent through browser Do correct parsing of http headers
2 participants
@jrriehl @Archento