Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: balance change handler typo #209

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Conversation

bryanchriswhite
Copy link

@bryanchriswhite bryanchriswhite commented Dec 7, 2022

Changes

  • fix copypasta - properly replace _handleNativeBalanceDecrement with _handleNativeBalanceIncrement 🤦
  • improve native balance change test to prevent regression going forward

Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Either the PR references an issue (via the "Development" combobox) or the description explains the need for the changes.
  • The PR appropriately sized.
  • The PR contains an idempotent DB migration.
  • I have verified the correctness of the DB migration using relevant data (e.g. test-generated data).
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@bryanchriswhite bryanchriswhite added C-bug Category: Something isn't working P-high Priority: High priority task labels Dec 8, 2022
@bryanchriswhite bryanchriswhite marked this pull request as ready for review December 8, 2022 15:35
Copy link
Member

@Jonathansumner Jonathansumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well caught!

@bryanchriswhite bryanchriswhite merged commit 3f2812d into main Dec 9, 2022
@bryanchriswhite bryanchriswhite deleted the fix/balance-change-typo branch December 9, 2022 09:35
bryanchriswhite added a commit that referenced this pull request Dec 12, 2022
* fetch/main:
  docs: readme: expand on how to use e2e tests (#216)
  feat: add contract relation to legacy bridge swap (#211)
  chore: remove redundant index decorator (#215)
  fix: balance change handler typo (#209)
  chore: amend contract field on cw20BalanceChange entity (#201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Something isn't working P-high Priority: High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants