Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: suppress failed txs #124

Merged
merged 10 commits into from
Oct 11, 2022
Merged

Fix: suppress failed txs #124

merged 10 commits into from
Oct 11, 2022

Conversation

Jonathansumner
Copy link
Member

Event-based handlers: suppress failed TXs - addressing #101

  • Convert handlers to trigger based on event types, then filter for message
  • Add malformed structure checks of entities

Any discussion about which failed entities should still persist?

@Jonathansumner Jonathansumner added this to the v0.2 milestone Oct 6, 2022
@Jonathansumner Jonathansumner self-assigned this Oct 6, 2022
@Jonathansumner Jonathansumner marked this pull request as ready for review October 10, 2022 11:27
@bryanchriswhite bryanchriswhite removed this from the v0.2 milestone Oct 10, 2022
@bryanchriswhite bryanchriswhite mentioned this pull request Oct 10, 2022
Closed
bryanchriswhite
bryanchriswhite suggested changes Oct 11, 2022
View reviewed changes
Copy link

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great @Jonathansumner! 🙌

I just had a few nit comments are about logging and line breaks.

This was linked to issues Oct 11, 2022
Testnet sync error #130
Closed
Ensure high-level entities from failed txs are not persisted #87
Closed
bryanchriswhite
bryanchriswhite approved these changes Oct 11, 2022
View reviewed changes
Copy link

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Jonathansumner!

@Jonathansumner Jonathansumner merged commit 307e8d6 into main Oct 11, 2022
@Jonathansumner Jonathansumner deleted the fix/suppress-failed-txs branch October 11, 2022 13:32
@bryanchriswhite bryanchriswhite linked an issue Oct 12, 2022 that may be closed by this pull request
Authz support (delegator claim bug) #82
Closed
@bryanchriswhite bryanchriswhite mentioned this pull request Nov 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanchriswhite bryanchriswhite bryanchriswhite approved these changes

Assignees

@Jonathansumner Jonathansumner

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Jonathansumner @bryanchriswhite