Read scalar values from OF #14
Merged
+45
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 96.05% 97.53% +1.47%
==========================================
Files 2 2
Lines 76 81 +5
==========================================
+ Hits 73 79 +6
+ Misses 3 2 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhdark
reviewed
Mar 7, 2025
|
|
||
| # Create dolfinx Mesh | ||
| mesh_ufl = ufl.Mesh(self.mesh_element) | ||
| mesh_ufl = ufl.Mesh(self.mesh_vector_element) |
There was a problem hiding this comment.
Could probably add a small inline comment here stating how the type of element for creating the mesh is not important
Comment on lines
+138
to
+141
| if name == "U": | ||
| element = self.mesh_vector_element | ||
| else: | ||
| element = self.mesh_scalar_element |
There was a problem hiding this comment.
Again could add small comment, in the case of reading for "U" a velocity field, a vector element is used etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.