This repository has been archived by the owner on Jul 6, 2021. It is now read-only.
Update readme instructions #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the commands in the readme results in the server starting on port 3000 and the client expects it to be on 8080, so we get the error: > Doh - disconnected - no snek running at localhost:8080 I've updated the instructions to set the port for the server, there is also a Procfile which the instructions don't use, it could be a good idea to have a single Procfile in the base directory that starts all 3 processes. Also the client doesn't use node, so no need to install packages via yarn.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the commands in the readme results in the server starting on
port 3000 and the client expects it to be on 8080, so we get the error:
I've updated the instructions to set the port for the server, there is also a
Procfile which the instructions don't use, it could be a good idea to have a
single Procfile in the base directory that starts all 3 processes.
Also the client doesn't use node, so no need to install packages via yarn.