fixed deprecated function errors with THREE #81
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powersimple
changed the title
|
This is needed for compatibility with A-Frame 1.4.0, as the deprecated THREE.js function setDynamic() has now been removed completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Fernando,
Small world that we were chatting the other day on LinkedIn.
Then this morning I found an A-Frame based site that I want to work with, and went into clean up errors. The first errors to clean up were easy deprecated functions for your teleport controls, all found in RayCurve.js.
(the site, if you're interested is https://www.anvropomotron.com/)
and these are the errors it threw.
I changed the first two and commented out the third. removing the drawMode call didn't seem to affect the site when I tested it.
three.js:49307 THREE.BufferAttribute: .setDynamic() has been deprecated. Use .setUsage() instead.
setDynamic @ three.js:49307
three.js:49334 THREE.BufferGeometry: .addAttribute() has been renamed to .setAttribute().
addAttribute @ three.js:49334
three.js:49099 THREE.Mesh: .drawMode has been removed. The renderer now always assumes THREE.TrianglesDrawMode. Transform your geometry via BufferGeometryUtils.toTrianglesDrawMode() if necessary.