-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command Line Arguments #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran python dpmData.py --help
and it simply ran the program rather than printing the help screen. Why isn't argparse working in this way?
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized we're missing a condition if we get just one of START_DATE
or END_DATE
. The rest of my comments and superficial. I'll approve the pull request once the condition is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once VIRT01 is removed this can be approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't run this but considering the change is small I'm betting this is good. Thanks. Sorry for the delay. I need to figure out notifications so I don't forget something like this again.
TO DO
closes #1