Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace xz library with newer one #135

Closed

Conversation

der-eismann
Copy link
Contributor

Reasoning:

  • Last commit in this repo was 7 years ago, project is dead
  • It's not versioned and doesn't have a go.mod
  • License can't be detected by pkg.go.dev & other tools
  • Causes pkg.go.dev to not show any documentation
  • Tools that check for license compliance might fail on embedded-postgres because it pulls in github.com/xi2/xz

@der-eismann der-eismann marked this pull request as draft March 21, 2024 15:01
@fergusstrange
Copy link
Owner

Awesome @der-eismann, would be be a great upgrade.

@der-eismann der-eismann force-pushed the replace-xz-library branch 2 times, most recently from 4b5840b to 1014054 Compare March 22, 2024 15:13
@Araoz-Lucas-bah
Copy link

can we move forward with this change? I want to include this in one of my projects, but the license check tooling is failing on this exact thing

@der-eismann
Copy link
Contributor Author

Unfortunately I have no idea why the tests on Windows and macOS are failing, I can't reproduce it here.

@fergusstrange
Copy link
Owner

Hmmm this is interesting @der-eismann. I can confirm your changes pass locally with an M2 Macbook. Perhaps try boosting the windows/mac build runners to see if you have any luck here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants