fix: updated axios sendRequest (#2063) #2067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backwards compatibility for axios vulnerable parameter
Collaborator
Author
|
Not sure how to force build, it has timeout on |
Collaborator
|
Which commands did you run @evgarthub? |
Collaborator
Author
|
I followed |
ferdikoomen
deleted the
2063-update-sendrequest-for-axios-to-align-on-parameter-deprecation-withcredentials
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2063
added backwards compatibility for axios vulnerable parameter
I checked all the changes for axios, and it looks like setting it to true when credentials are forced for any domain is the right choice.
I'm not able to run the tests properly as #2052 causes wrong paths to be resolved.
I will take a look at that PR and see if it helps.