BaseEncoder: prepare mediacodec on nonnull callback

See #21 MediaCodec maybe crash on some devices due to null callback
fengzhiyuanyi · May 24, 2018 · 3db3992 · 3db3992
1 parent 8dadf5b
commit 3db3992
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/app/src/main/java/net/yrom/screenrecorder/BaseEncoder.java b/app/src/main/java/net/yrom/screenrecorder/BaseEncoder.java
@@ -79,7 +79,10 @@ public void prepare() throws IOException {
         String mimeType = format.getString(MediaFormat.KEY_MIME);
         final MediaCodec encoder = createEncoder(mimeType);
         try {
-            encoder.setCallback(this.mCallback == null ? null : mCodecCallback);
+            if (this.mCallback != null) {
+                // NOTE: MediaCodec maybe crash on some devices due to null callback
+                encoder.setCallback(mCodecCallback);
+            }
             encoder.configure(format, null, null, MediaCodec.CONFIGURE_FLAG_ENCODE);
             onEncoderConfigured(encoder);
             encoder.start();