Add connectTimeout LdapConnection field with default value of 5000 ms. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the timeout value to use when creating new TCP connections. In general this is most obvious when attempting to connect to the LDAP server for the first time. If it is not reachable one would normally want the connection attempt to end ASAP. For more info the node-ldapjs docs at: https://github.com/ldapjs/node-ldapjs/blob/8ffd0bc9c149088a10ec4c1ec6a18450f76ad05d/docs/client.md#create-a-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable connection timeout value to use when creating new TCP connections. In general the effect of this is most obvious when attempting to connect to the LDAP server for the first time. If it is not reachable, one would normally want the connection attempt to end ASAP.
In my case I connect to LDAP servers over VPN and sometimes the VPN is not on, so the extension tries to connect forever (infinity) and this forces me to close and reopen VScode.
I think it's set to 0 (infinity) by default in node-ldapjs: https://github.com/ldapjs/node-ldapjs/blob/8ffd0bc9c149088a10ec4c1ec6a18450f76ad05d/lib/client/client.js#L124