Support building on Windows #293
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has most of the changes that would be needed to support building on Windows using MinGW. Tests are not passing yet (some weird open file handle limitations on the GitHub Action VMs?).
The biggest limitation is that shell filters needed to be disabled since a native POSIX compatible ‘sh’ isn’t really available on Windows, and the forking/exec/pipes to spawn the subprocess are tricky to convert.
There are several things related to file access and temp file creation could be cleaned up by using std::filesystem.
Memory mapping and a few other read functions can be addressed with some Windows alternatives, though there may also be opportunities to leverage more C++17 standard library features to make those parts of the code more portable. And there are a few things like madvise that just don’t seem to have a Windows equivalent.