Skip to content

Commit

Permalink
[RN] Set enableOwnerStacks and enableUseDeferredValueInitialArg to false
Browse files Browse the repository at this point in the history
In www, the experimental versions get a .modern.js or .classic.js prefix
and get copied into the same folder. In RN, they don't seem to have
.modern.js and .classic.js versions so they end up getting the same
name.

sebmarkbage's theory is that what happens is that they then override
the file that was already there. So depending on if experimental or
stable build finishes first you get a different version at the end.

It doesn't make sense to use `__EXPERIMENTAL__` for flags in native-fb
since there's no modern/classic split there. So that flag should just be
hardcoded to true or false and then it doesn't matter which one finishes
first.

We don't support experimental builds in OSS RN neither so the same thing
could happen with
[`enableOwnerStacks`](https://github.com/facebook/react/blob/5dcf3ca8d45a276a8b4cee0cedd234967661ca35/packages/shared/forks/ReactFeatureFlags.native-oss.js#L60).

You can see that the build errors in the previous PR but passes after
these flag changes.

ghstack-source-id: d10f37bcea0e485fdb4f136370c179999badd560
Pull Request resolved: facebook#30322
  • Loading branch information
felixshiftellecon committed Jul 24, 2024
1 parent ff3f1fa commit 8e0ef50
Show file tree
Hide file tree
Showing 10 changed files with 931 additions and 553 deletions.
816 changes: 281 additions & 535 deletions .circleci/config.yml

Large diffs are not rendered by default.

9 changes: 6 additions & 3 deletions .github/workflows/compiler_playground.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ on:
branches: [main]
pull_request:
paths:
- "compiler/**"
- compiler/**
- .github/workflows/compiler-playground.yml

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

defaults:
run:
working-directory: compiler
Expand All @@ -20,8 +23,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: compiler/yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/compiler_rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ on:
env:
CARGO_TERM_COLOR: always
RUSTFLAGS: -Dwarnings
TZ: /usr/share/zoneinfo/America/Los_Angeles

defaults:
run:
Expand Down
17 changes: 10 additions & 7 deletions .github/workflows/compiler_typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ on:
branches: [main]
pull_request:
paths:
- "compiler/**"
- compiler/**
- .github/workflows/compiler-typescript.yml

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

defaults:
run:
working-directory: compiler
Expand All @@ -31,8 +34,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: compiler/yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand All @@ -50,8 +53,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: compiler/yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand All @@ -74,8 +77,8 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
cache: "yarn"
node-version: 18.20.1
cache: yarn
cache-dependency-path: compiler/yarn.lock
- name: Restore cached node_modules
uses: actions/cache@v4
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/devtools_check_repro.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
issue_comment:
types: [created, edited]

env:
TZ: /usr/share/zoneinfo/America/Los_Angeles

jobs:
check-repro:
runs-on: ubuntu-latest
Expand Down
Loading

0 comments on commit 8e0ef50

Please sign in to comment.