This repository has been archived by the owner on Sep 11, 2021. It is now read-only.
Add ARM64 Windows tool option #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The approach looks good to me, thanks for the PR! I'd love a bit of assistance for the user though – could we only add this extra parameter if we're actually installing the 2017 tools? (Nevermind the build failure, the CI currently doesn't correctly work for non-trusted PRs) |
Since Node.js is expected to support ARM64 Windows natively soon, this change adds an option to the module, '--include-arm64-tools', to install the extra Visual Studio 2017 bits required to build native modules for it.
jkunkee
force-pushed
the
add-arm64-bits
branch
from
5d1fa35
to
08884ec
Compare
|
How does this look? Also, as simple as this change is, do you have a convenient rig for testing it? If not, I'll eventually spin up a fresh VM and give it a shot. (I'm the one asking for the change, after all. :) |
|
I do not, for a full end-to-end test I usually just download a |
|
Let's just merge this and hope that it actually work 🙈 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With support for ARM64 Windows coming soon (nodejs/node#25998), I would like to see the tool that node-gyp recommends at least offer the option to install the ARM64 libraries needed for building native modules.
The initial version of this change takes a simple approach. I'm happy to rework it completely.
Also, this may be a simple change, but I haven't yet tried it.