Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease of use helpers for config led dynamic queue defs with compose wrapper. #799

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

colinjonesx
Copy link
Contributor

I needed these things to make bull-board more usable in my use case.

Hope it'll help adoption.

Not sure if it can be templatised, to apply to the other server patterns?

console.log('To populate the queue, run:');
console.log(' curl http://localhost:3000/add?title=Example');
console.log(' curl http://localhost:3333/add?title=Example');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should use the serverOptiosn.host & port, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good challenge!

Sorry - an oversight, the exposed port is configured in docker-compose.yml, which is pinned to 3333 in config.

I should remove serverOptions and hardcode to 0.0.0.0 and 3000 as this is implicit in compose config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest commit addresses the issue

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see usage of 3333 port, why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port 3000 is an arbitrary albeit conventional port for nodejs applications. From my perspective moving the exposed port to anything is a reasonable thing to do, especially where the primary application (the one posting to or subscribing to the MQ is likely going to reside on that port. With bull-board, as pretty as it is, being an ancillary support app, it seems to be a logical move.

If you would like me to revert to 3000 I can, but obvs I'll be running on 3333 locally.

- .env

ports:
- 3333:3000
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map 3000:3000

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?
Can you change the 3333 to 3000 in all the places?

@felixmosh felixmosh merged commit 7b4444d into felixmosh:master Aug 29, 2024
@felixmosh
Copy link
Owner

Thank you 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants