New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance basic-auth.middleware example with password hashing and env variables #782

Merged

felixmosh merged 1 commit into felixmosh:master from vincenzodomina:master

Jun 30, 2024

Contributor

vincenzodomina commented Jun 28, 2024

I have elaborated on the basic auth example to be more production friendly, of course open for feedback.

Changes

Replace hardcoded credentials with ConfigService-based configuration
Implement bcrypt for secure password hashing and comparison
Improve error handling and code structure

This change significantly improves the security of the Bull Board authentication


          Update basic-auth.middleware.ts with bcrypt hashing

65ad26a

Owner

felixmosh commented Jun 30, 2024

Hi @vincenzodomina thank you for this improvments

felixmosh merged commit 42ca519 into felixmosh:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet