feat(adapters): support hono v4 #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thank you for this PR 🙏🏽 |
|
thanks king, right about time i started looking into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Hono V4. Since the adapters are not versioned separately, I tried to make a minimally-breaking change - it requires no changes unless you use Cloudflare Workers, which has a breaking change in Hono v41.
This makes the types in the
HonoAdapterslightly unsound. A proper long-term fix would be to change the API to accepthandler: ({ root, rewriteRequestPath }) => MiddlewareHandler(whereMiddlewareHandleris the return type ofserveStatic).Consumers could then construct
serveStaticthemselves, including requirements such as the manifest. That would, of course, require every consumer to update theirHonoAdapterconstructor, so maybe something to reserve for a major release.Closes #721 (supersedes)
Footnotes
https://github.com/honojs/hono/blob/main/docs/MIGRATION.md#servestatic-in-cloudflare-workers-adapter-requires-manifest ↩