Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Group Queues by Category #739

Closed
wants to merge 18 commits into from
Closed

Conversation

manfe
Copy link

@manfe manfe commented May 10, 2024

This PR introduces:

  • Queue categories, but keeping backwards compatibility setting a default category.
  • Search Provider so we can reflect search results in all parts of the app.

How it works:

Screen.Recording.2024-05-10.at.20.37.57.mov

}

public getDescription(): string {
return this.description;
}

public getCategory(): string {
return (this.category || 'default').toUpperCase();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the uppercase?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ideia is to normalize the data, otherwise Category 1 and category 1 will be distinct.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to remove uppercase here and treat it in another leve, since the category property at base adapter is public, otherwise getCategory and class.category can return different data.

@felixmosh
Copy link
Owner

Hi @manfe thank you for the PR.
It is a great feature, but I would like you to make small changes.

  1. Queue search should remain on the left menu (as it was) (your position dosn't make any sense)
  2. Full backward compatability, to keep the current view (if there is only one category, show the corrent view, without collapse & group)
  3. In order to make the code review easier for me, split this PR into several small PRs 🙏🏽,
  4. Don't change example.ts, but add a new example in the examples folder.

@manfe
Copy link
Author

manfe commented May 13, 2024

@felixmosh regarding your points.

  1. With this PR the search turned global on app and I also want address some responsiveness. The search at top bar from UX works better, because the search is reflecting in the overview page. And for responsiveness the sidebar can be hidden without losing of search feature. Also thinking a little ahead, having search at top bar, probably sidebar will turn useless and the UI can be simplified.

  2. Originally I did that, but I thought that just a default word wouldn't be a problem, and also it was going to motive people using categories to organize their queues. PS: when there is only one category it always start as expanded), but if you really think it's a big deal, I can address it.

  3. Ok, I am going to do these steps:

  1. I am going to create it, with Category Property PR

@manfe
Copy link
Author

manfe commented May 13, 2024

How I am imagining the UX improvement:

image

@manfe
Copy link
Author

manfe commented May 13, 2024

After having #740 and #741

We can discuss the best implementation for UI/UX part.

That's work for you @felixmosh ?

@felixmosh
Copy link
Owner

Hi thanks, I'm AFK till Wednesday.
Will review ASAP

@manfe manfe closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants