Update Header.module.css #724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refine styling of Header to match font-size to other header elements.
|
|
|
Hi @jcottam what issue did you solved? |
|
Hi @felixmosh. The update is purely cosmetic, no bug fix or feature improvement here. I modified the CSS of the "Bull Dashboard" header to have a smaller font and left-align. I feel the update provides a cleaner look and allows for more characters in the header if needed. Header is quite large in the current release (see below):
|
|
Hi, thanx for the PR, but looks like you are not fixing any issue but changing the design to meet your teste :] BTW, I'm using a known typo scale, so it is not just random numbers. Maybe It is possible to "jump" one layer below... to 1.44rem |
|
1.44rem looks good! Thanks for sharing the extra context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine styling of Header to match font-size to other header elements. Cleaner look.