Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option for ignoreMissing - Fixes #64 #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aetherwalker
Copy link

No description provided.

When requiring a file, if the filesystem doesn't have the file path
specified, a missing file error is thrown by "require-like". This adds
an option "ignoreMissing" that skips the error with a simple try/catch
to allow the sandboxing to continue.
@nomiddlename
Copy link

I extended this to work with modules that are required by sandboxed modules as well. Take a look at this commit for the details. Not sure of the best way to incorporate that into this PR, @aetherwalker . Anyway, my fork is published to NPM as @log4js-node/sandboxed-module, but I'd be happy to remove if this change is merged - in the meantime feel free to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants