Fix loading sources with a shebang (#!) #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 7, 2014 15:50
Sources ending with an end-of-line comment (not followed by a newline character) aren't wrapped properly. The second part of the wrapper is treated as part of the comment in such a case. Adding a newline character in fixes this issue.
Fixes loading modules of which the source starts with a shebang (#!). In line with Node's native module loader, they don't cause a syntax error anymore upon compilation. See https://github.com/joyent/node/blob/7c0419730b237dbfa0ec4e6fb33a99ff01825a8f/lib/module.js#L380 .
|
Can you add a test? |
|
Done |
|
Merged as fc70699 and will release as 1.0.3 shortly. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes loading modules of which the source starts with a shebang (#!). In line with Node's native module loader, they don't cause a syntax error anymore upon compilation. See https://github.com/joyent/node/blob/7c0419730b237dbfa0ec4e6fb33a99ff01825a8f/lib/module.js#L380 .