Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corruption. NEVER use SPI method transfer on a pointer. #473

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

xxxajk
Copy link
Contributor

@xxxajk xxxajk commented Jul 2, 2019

Should fix the problems.
Also removes duplicate code.

@gdsports
Copy link
Contributor

gdsports commented Jul 3, 2019

The USBPrinter_uhs2 driver works with this patch using Uno and Leonardo. I do not have a Mega 2560 but the patch should work. Also the printer is confirmed to work on ESP8266. I will withdraw PR #470 since it is redundant.

BTW, M5Stack released a USB host MAX3421E module so I will be testing this out when I receive one. M5Stack is an ESP32 based system of stackable modules. The modules are like shields but include plastic casing so the module stack is professional looking.

https://m5stack.com/collections/m5-module/products/usb-module

@Lauszus
Copy link
Collaborator

Lauszus commented Jul 24, 2019

Is this ready to merge?

@gdsports
Copy link
Contributor

It has been working fine for me.

@Lauszus Lauszus merged commit 821e37e into felis:master Aug 5, 2019
@Lauszus
Copy link
Collaborator

Lauszus commented Aug 5, 2019

Thanks for the report @gdsports. I'll make a new release as well, so all the people that are using the Arduino library manager will get the update as well.

@Bacto
Copy link

Bacto commented Jan 4, 2020

Hi everyone ant thanks for this library :)
Do you have any news about the next release?
The last one is from 2018/15/03 and does not include this fix unfortunately :-/

@Vamshi253
Copy link

Hi @gdsports,

The USBPrinter_uhs2 driver is not working with this patch using Arduino Mega ADK. Could you please suggest any changes that I need to make in order to work out with Arduino Mega ADK.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants