New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanish tag #49

Open

felipeochoa wants to merge 1 commit into master from vanish-tag

Owner

felipeochoa commented Sep 28, 2017 •

edited

Loading

Especially with React 16, it would be nice to have a single command to unwrap the children of a tag and splice them into the surroundings:

let c = <Parent><Child/><Parent>; // point on Parent

after vanishing parent should give:

let c = <Child/>; // point right before Child

Initial implementation
Clean up whitespace outside the removed tag (e.g., extra newlines)
Clean up whitespace when first/last child are text nodes
Fix indentation for children
If only child is text, wrap it in quotes
Set point and mark to the start/end of the child region (or reversed if point was on the closer)
Add tests


          initial vanish-tag implementation

de3fb4f

Need to figure out how to clean up whitespace around tag and add tests

felipeochoa force-pushed the vanish-tag branch from 967df10 to de3fb4f Compare

October 10, 2017 11:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet