Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commits #4

Merged
merged 87 commits into from
Mar 18, 2024
Merged

First commits #4

merged 87 commits into from
Mar 18, 2024

Conversation

felddy
Copy link
Owner

@felddy felddy commented Mar 18, 2024

🗣 Description

First commits of new project.

💭 Motivation and context

My screen reader couldn't read some of the pdfs that were provided to me, which made it difficult to comprehend.

This code fixes that issue.

🧪 Testing

Tested locally and in CI/

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

felddy added 30 commits March 17, 2024 20:30
Fixed a bug with scrub causing a seg-fault
@felddy felddy self-assigned this Mar 18, 2024
@coveralls
Copy link

coveralls commented Mar 18, 2024

Pull Request Test Coverage Report for Build 8319586995

Details

  • 113 of 604 (18.71%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-84.8%) to 15.194%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pdf_access/bases.py 13 16 81.25%
src/pdf_access/actions/keep_pages.py 0 18 0.0%
src/pdf_access/registry.py 7 25 28.0%
src/pdf_access/actions/delete_piece_info.py 0 24 0.0%
src/pdf_access/actions/delete_trailer_id.py 0 24 0.0%
src/pdf_access/config_model.py 36 60 60.0%
src/pdf_access/actions/encoding_diff.py 0 26 0.0%
src/pdf_access/post_process/gs_compress.py 0 31 0.0%
src/pdf_access/actions/clear_stream.py 0 32 0.0%
src/pdf_access/actions/gated_regex.py 0 45 0.0%
Totals Coverage Status
Change from base Build 8319439176: -84.8%
Covered Lines: 115
Relevant Lines: 606

💛 - Coveralls

@felddy felddy merged commit f889ac6 into develop Mar 18, 2024
23 checks passed
@felddy felddy deleted the first-commits branch March 18, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants