Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login form parameters to match new identifiers on site #870

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

felddy
Copy link
Owner

@felddy felddy commented Jan 5, 2024

🗣 Description

The FoundryVTT web site login changed the name of the fields in the login form. This broke authentication.
This PR changes the names of the posted fields to match the new form's expectations.

💭 Motivation and context

Notified of

See:

Closes #868

🧪 Testing

Tested in node via CLI and in continuous integration.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@felddy felddy self-assigned this Jan 5, 2024
@felddy felddy merged commit cc6f477 into develop Jan 5, 2024
38 checks passed
@felddy felddy deleted the bugfix/issue-868 branch January 5, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foundry website login change broke authentication helper utility
1 participant