fix: stringify instance with long properties #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
approved these changes
Feb 8, 2021
felangel
added
bug
Closed
|
#95 ???? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
When calling
toStringon a longIterable, dart will omit some of the elements (this is a feature), see Iterable#toString.This causes, when stringify an equatable with very long properties, some of the properties got omitted.
This pr fixes it.
Related Issues
#94
Related PRs
List related PRs against other branches:
Todos
Steps to Test or Reproduce
See the test
with SuperLongProperties stringify, the old code will not pass this test.Impact to Remaining Code Base
This PR will affect:
toStringmethod of Equatable subclasses with long enough properties andstringify = true