[DEV-4997] Data Transparency UI Configuration Update #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…website into ftr/dev-4997/dtui-config-update
MaxwellKendall
commented
Jun 2, 2020
package.json
Outdated
| @@ -80,7 +80,7 @@ | |||
| "d3-interpolate": "^1.1.4", | |||
| "d3-scale": "^1.0.4", | |||
| "d3-time": "^1.0.11", | |||
| "data-transparency-ui": "github:fedspendingtransparency/data-transparency-ui#v1.1.1", | |||
| "data-transparency-ui": "github:fedspendingtransparency/data-transparency-ui#mod/dev-4997/optimize-config", | |||
There was a problem hiding this comment.
need to update this one sec!!
ebdabbs
suggested changes
Jun 2, 2020
ebdabbs
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level description:
Removing special webpack config & updating css import
Technical details:
No longer need to compile the dt-ui library. Weird import statement for our styles as well? Fixed that.
JIRA Ticket:
DEV-4997
The following are ALL required for the PR to be merged:
Author:
Reviewer(s):