Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10929 - css change; new version number; and build files #201

Merged
merged 1 commit into from
May 7, 2024

Conversation

brianpetway
Copy link
Contributor

Check List Before Merging

Author

  • [x ] Story Book has been rebuilt (new build artifacts in /docs)
  • [x ] Components have been rebuilt (new build artifacts in /dist)

👆These can be done by executing npm run build and committing the build artifacts.

  • All new components have been exported in /index.js (if applicable)
  • Design Review Complete
  • Relevant Draft release notes have been updated describing these changes (use this template to document your changes) (if applicable)
  • Integration Status Updated on relevant documentation page (if applicable)
  • index.d.ts updated with new prop types defined for new components. (if applicable)

Reviewer

  • Code review

@brianpetway brianpetway changed the title 10929 - css change; new verison number; and build files 10929 - css change; new version number; and build files May 7, 2024
@nick-torres nick-torres self-assigned this May 7, 2024
@nick-torres
Copy link
Contributor

there is a disconnect somewhere here bc i built and npm packed this and installed it in usas and went to advanced search results and expected to see row highlighting on my table, the table styles are not being properly applied

@brianpetway
Copy link
Contributor Author

But you can see the rows highlight correctly in Storybook, right?

@nick-torres
Copy link
Contributor

yessir thats why i know something is screwing it up in usas, almost all the work you've done on table styling isn't showing up

@nick-torres nick-torres merged commit e8e90c3 into master May 7, 2024
@nick-torres nick-torres deleted the mod/10929-search-results-table-row-hover branch May 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants