10516 - cleanup the dtui in-page nav component #184
Conversation
helpers/inPageNavHelper.js
Outdated
| * inPageNavHelper.js | ||
| * Created by Andrea Blackwell 01/16/24 | ||
| */ | ||
| import {useCallback} from "react"; |
There was a problem hiding this comment.
looks like this isn't used
helpers/inPageNavHelper.js
Outdated
| export const checkIsOverflow = (ulEl, padding) => { | ||
| let left = false; | ||
| let right = false; | ||
| console.log(ulEl, padding); |
There was a problem hiding this comment.
a few console logs in this block
| statements: -10 | ||
| } | ||
| }, | ||
| // coverageThreshold: { |
There was a problem hiding this comment.
did you mean to leave this commented out?
|
A few inline comments. The testing strategy is very clever, that must have taken a minute to arrive at. |
|
Also, do you need to add the new dtui version number in this branch? |
|
Yeah I could see the tests I added being helpful during development given the issues with calculating the overflow but not sure how helpful this is now. we could add test for the padding issue in another ticket. |
Check List Before Merging
Author
/docs)/dist)👆These can be done by executing
npm run buildand committing the build artifacts./index.js(if applicable)(if applicable)(if applicable)index.d.tsupdated with new prop types defined for new components.(if applicable)Reviewer