Mod 10104 #172
Merged
Mod 10104 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
you need to update the version, commit the rebuilt artifacts |
|
Added the rebuild |
nick-torres
reviewed
Aug 16, 2023
styles/components/_pageHeader.scss
Outdated
| @@ -34,6 +34,16 @@ $z-header: 100; | |||
| @include for-tablet-landscape-up { | |||
| flex-wrap: nowrap; | |||
| } | |||
| hr { | |||
| display: blocks; | |||
| background-color: rgba(223, 225, 226, 0.25); | |||
There was a problem hiding this comment.
is there a reason that you're using the rgb function here versus a color variable? i'm not saying you should be using a variable here i'm just curious
nick-torres
reviewed
Aug 16, 2023
| background: $gray-cool-5; | ||
| border: solid 2px rgba(26, 68, 128, 0.25); | ||
| background:$blue-warm-70v; | ||
| border: solid 2px rgba(223, 225, 226, 0.25); |
There was a problem hiding this comment.
that what was used before hand so I kept it the same. I can use a var. But figured it was a rgba before hand just keep it.
There was a problem hiding this comment.
@nick-torres changed them
nick-torres
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List Before Merging
DropdownItem
Author
/docs)/dist)👆These can be done by executing
npm run buildand committing the build artifacts./index.js(if applicable)(if applicable)(if applicable)index.d.tsupdated with new prop types defined for new components.(if applicable)Reviewer